Wasmtime GitHub notifications bot (Feb 18 2022 at 16:43): Wasmtime GitHub notifications bot (Feb 18 2022 at 16:43):cfallin opened PR #3831 from configurable-dense-memory-image-limit to main:
In #3820 we see an issue with the new heuristics that control use of
memfd: it's entirely possible for a reasonable Wasm module produced by a
snapshotting system to have a relatively sparse heap (less than 50%
filled). A system that avoids memfd because of this would have an
undesirable performance reduction on such modules.Ultimately we should try to implement a hybrid scheme where we support
outlier/leftover initializers, but for now this PR makes the "always
allow dense" limit configurable. This way, embedders that want to ensure
that memfd is used can do so, if they have other knowledge about the
maximum heap size allowed in their system.(Partially addresses #3820 but let's leave it open to track the hybrid
idea)<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 18 2022 at 16:43):cfallin requested alexcrichton for a review on PR #3831.
Wasmtime GitHub notifications bot (Feb 22 2022 at 15:17):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 22 2022 at 17:07):cfallin updated PR #3831 from configurable-dense-memory-image-limit to main.
Wasmtime GitHub notifications bot (Feb 22 2022 at 17:31):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 22 2022 at 17:35):cfallin updated PR #3831 from configurable-dense-memory-image-limit to main.
Wasmtime GitHub notifications bot (Feb 22 2022 at 18:40):alexcrichton merged PR #3831.
Last updated: Dec 23 2024 at 13:07 UTC