Stream: git-wasmtime

Topic: wasmtime / PR #3823 Limit total memory usage in instantia...

Wasmtime GitHub notifications bot (Feb 17 2022 at 16:12):

alexcrichton opened PR #3823 from instantiate-many-less-memor to main:

Per-Store allocations are already limited with the StoreLimits
structure while fuzzing to ensure fuzz targets don't allocate more than
1GB of memory, but the instantiate-many fuzzer created many separate
stores which each had their own limit, meaning that the 2GB limit of
fuzzing could be pretty easily reached.

This commit fixes the issue by making StoreLimits a shareable type via
Rc to ensure the same limits can be applied to all stores created
within a fuzz run, globally limiting the memory even across stores to 1GB.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 17 2022 at 16:12):

alexcrichton requested peterhuene for a review on PR #3823.

Wasmtime GitHub notifications bot (Feb 17 2022 at 18:26):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Feb 17 2022 at 18:26):

fitzgen merged PR #3823.

Last updated: Nov 22 2024 at 16:03 UTC