Stream: git-wasmtime

Topic: wasmtime / PR #3821 x64: enable VTune support by default

Wasmtime GitHub notifications bot (Feb 17 2022 at 01:16):

abrown opened PR #3821 from default-vtune to main:

After significant work in the ittapi-rs crate, this dependency should
build without issue on Wasmtime's supported operating systems: Windows,
Linux, and macOS. The difference in the release binary is <20KB, so this
change makes vtune a default build feature. This change upgrades
ittapi-rs to v0.2.0 and updates the documentation.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 17 2022 at 08:30):

bnjbvr submitted PR review.

Wasmtime GitHub notifications bot (Feb 17 2022 at 16:53):

abrown updated PR #3821 from default-vtune to main.

Wasmtime GitHub notifications bot (Feb 17 2022 at 18:48):

abrown updated PR #3821 from default-vtune to main.

Wasmtime GitHub notifications bot (Feb 17 2022 at 20:53):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 17 2022 at 20:53):

alexcrichton created PR review comment:

Oh due to how Cargo features work this only wants to be defaulted from wasmtime and wasmtime-cli, otherwise from this crate it should be off-by-default.

Wasmtime GitHub notifications bot (Feb 17 2022 at 20:53):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 17 2022 at 21:39):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Feb 17 2022 at 21:39):

abrown created PR review comment:

Ok, removing...

Wasmtime GitHub notifications bot (Feb 17 2022 at 21:42):

abrown updated PR #3821 from default-vtune to main.

Wasmtime GitHub notifications bot (Feb 21 2022 at 11:09):

bnjbvr submitted PR review.

Wasmtime GitHub notifications bot (Feb 21 2022 at 11:09):

bnjbvr submitted PR review.

Wasmtime GitHub notifications bot (Feb 21 2022 at 11:09):

bnjbvr created PR review comment:

hmm, it seems the end of this comment after -- would need to be removed, as it contains : but with no extra indication thereafter?

Wasmtime GitHub notifications bot (Feb 22 2022 at 16:31):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Feb 22 2022 at 16:31):

abrown created PR review comment:

It's setting up the list of ways to enable VTune at runtime (if I understand what you mean).

Wasmtime GitHub notifications bot (Feb 22 2022 at 16:32):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Feb 22 2022 at 16:32):

abrown created PR review comment:

I'll leave it and we can fix it up later if we think of a more clear way to word this.

Wasmtime GitHub notifications bot (Feb 22 2022 at 16:32):

abrown merged PR #3821.

Wasmtime GitHub notifications bot (Feb 22 2022 at 16:32):

bnjbvr submitted PR review.

Wasmtime GitHub notifications bot (Feb 22 2022 at 16:32):

bnjbvr created PR review comment:

Oh, i misread it as a list entry as well, my bad. Maybe can reformulate slightly then:

the `ittapi` library of JIT events. But it must still be enabled at
runtime with one of the following:

Last updated: Nov 22 2024 at 16:03 UTC