Stream: git-wasmtime

Topic: wasmtime / PR #3820 add a config field that allows us to ...

Wasmtime GitHub notifications bot (Feb 17 2022 at 00:13):

pchickey opened PR #3820 from pch/mlock_experiment to main:

Needs benchmarking before this is considered seriously.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 17 2022 at 04:27):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 17 2022 at 04:27):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 17 2022 at 04:27):

alexcrichton created PR review comment:

I think that if this loop were moved to Module::from_parts it should catch all cases of module construciton and avoid the need to special case deserialize_file

Wasmtime GitHub notifications bot (Feb 17 2022 at 04:27):

alexcrichton created PR review comment:

With my above suggestion of moving to Module::from_parts I think that means this could probably be removed

Wasmtime GitHub notifications bot (Feb 17 2022 at 17:57):

pchickey updated PR #3820 from pch/mlock_experiment to main.

Wasmtime GitHub notifications bot (Feb 17 2022 at 18:39):

pchickey updated PR #3820 from pch/mlock_experiment to main.

Wasmtime GitHub notifications bot (Mar 17 2022 at 22:05):

alexcrichton updated PR #3820 from pch/mlock_experiment to main.

Wasmtime GitHub notifications bot (Mar 17 2022 at 22:32):

alexcrichton updated PR #3820 from pch/mlock_experiment to main.

Wasmtime GitHub notifications bot (Mar 18 2022 at 14:38):

alexcrichton updated PR #3820 from pch/mlock_experiment to main.

Wasmtime GitHub notifications bot (Mar 18 2022 at 17:59):

pchickey closed without merge PR #3820.

Last updated: Nov 22 2024 at 16:03 UTC