Stream: git-wasmtime

Topic: wasmtime / PR #3816 Cranelift: ensure ISA level needed fo...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2022 at 20:20):

cfallin opened PR #3816 from simd-require-sse41 to main:

Addresses #3809: when we are asked to create a Cranelift backend with
shared flags that indicate support for SIMD, we should check that the
ISA level needed for our SIMD lowerings is present.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2022 at 20:20):

cfallin requested abrown for a review on PR #3816.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2022 at 20:20):

cfallin requested alexcrichton for a review on PR #3816.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2022 at 20:30):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2022 at 20:40):

cfallin updated PR #3816 from simd-require-sse41 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2022 at 21:44):

cfallin updated PR #3816 from simd-require-sse41 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2022 at 21:54):

cfallin updated PR #3816 from simd-require-sse41 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2022 at 22:04):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2022 at 00:01):

cfallin updated PR #3816 from simd-require-sse41 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2022 at 00:12):

cfallin updated PR #3816 from simd-require-sse41 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2022 at 00:14):

cfallin updated PR #3816 from simd-require-sse41 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2022 at 00:48):

cfallin updated PR #3816 from simd-require-sse41 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2022 at 01:29):

cfallin merged PR #3816.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2022 at 10:51):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2022 at 10:51):

bjorn3 created PR review comment:

This means explicitly using the baseline preset will now incorrectly include these flags, right?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2022 at 18:06):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2022 at 18:06):

cfallin created PR review comment:

Will include those flags, yes; "incorrectly" is a matter of interpretation, as we effectively need them at the moment to support our default enable_simd setting. Otherwise a default config will not work with default Wasmtime settings.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2022 at 13:01):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2022 at 13:01):

bjorn3 created PR review comment:

If I enable the baseline preset and not enable_simd, then these features shouldn't be enabled as it won't run on a cpu only implementing the x86_64 baseline. Maybe add them as dependency of enable_simd or enable them in wasmtime?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 23 2022 at 18:21):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 23 2022 at 18:21):

cfallin created PR review comment:

We could do it that way as well; happy to take a PR if you want to refactor in that direction. From my point of view, this should be relatively temporary anyway, as we should eventually (#3810) be able to do SIMD without any optional extensions.


Last updated: Dec 23 2024 at 13:07 UTC