Wasmtime GitHub notifications bot (Feb 16 2022 at 19:07): Wasmtime GitHub notifications bot (Feb 16 2022 at 19:07):alexcrichton opened PR #3814 from require-simd-things to main:
This commit unconditionally enables some x86_64 instructions when
fuzzing because the cranelift backend is known to not work if these
features are disabled. From discussion on the wasm simd proposal the
assumed general baseline for running simd code is SSE4.1 anyway.At this time I haven't added any sort of checks in Wasmtime itself.
Wasmtime by default uses the native architecture and when explicitly
enabling features this still needs to be explicitly specified.Closes #3809
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 16 2022 at 19:10):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2022 at 19:43):abrown submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2022 at 19:43):abrown submitted PR review.
Wasmtime GitHub notifications bot (Feb 16 2022 at 19:43):abrown created PR review comment:
// Wasmtime. Currently some SIMD code generation will
Wasmtime GitHub notifications bot (Feb 16 2022 at 19:57):alexcrichton updated PR #3814 from require-simd-things to main.
Wasmtime GitHub notifications bot (Feb 16 2022 at 20:53):alexcrichton merged PR #3814.
Last updated: Oct 23 2024 at 20:03 UTC