Stream: git-wasmtime

Topic: wasmtime / PR #3802 [AArch64] Merge 32- and 64-bit ALUOps

Wasmtime GitHub notifications bot (Feb 15 2022 at 15:15):

sparker-arm opened PR #3802 from aarch64-32-64-alu-ops to main:

Combine the two opcodes into one and pass and add an OperandSize
field to these instructions, as well as an ISLE helper to perform
the conversion from Type.

This saves us from having having to write ISLE helpers to select the
correct opcode, based on type, and reduces the amount of code needed
for emission.

Copyright (c) 2022, Arm Limited.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 15 2022 at 15:16):

sparker-arm edited PR #3802 from aarch64-32-64-alu-ops to main:

Combine the two opcodes into one and add an OperandSize
field to these instructions, as well as an ISLE helper to perform
the conversion from Type.

This saves us from having having to write ISLE helpers to select the
correct opcode, based on type, and reduces the amount of code needed
for emission.

Copyright (c) 2022, Arm Limited.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 17 2022 at 02:12):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 17 2022 at 02:12):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 17 2022 at 02:12):

cfallin created PR review comment:

In cases where only the 64-bit type is possible, can we assert here? Likewise for each similar match below.

Wasmtime GitHub notifications bot (Feb 17 2022 at 14:45):

sparker-arm updated PR #3802 from aarch64-32-64-alu-ops to main.

Wasmtime GitHub notifications bot (Feb 17 2022 at 15:18):

sparker-arm updated PR #3802 from aarch64-32-64-alu-ops to main.

Wasmtime GitHub notifications bot (Feb 17 2022 at 15:54):

sparker-arm updated PR #3802 from aarch64-32-64-alu-ops to main.

Wasmtime GitHub notifications bot (Feb 17 2022 at 18:03):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 17 2022 at 18:03):

cfallin merged PR #3802.

Last updated: Dec 23 2024 at 12:05 UTC