Stream: git-wasmtime

Topic: wasmtime / PR #3790 Minor instantiation benchmark updates

Wasmtime GitHub notifications bot (Feb 10 2022 at 19:26):

alexcrichton opened PR #3790 from benchmark-tweaks to main:

This commit has a few minor updates and some improvements to the
instantiation benchmark harness:

• A once_cell::unsync::Lazy type is now used to guard creation of
  modules/engines/etc. This enables running singular benchmarks to be
  much faster since the benchmark no longer compiles all other
  benchmarks that are filtered out. Unfortunately I couldn't find a way
  in criterion to test whether a BenchmarkId is filtered out or not so
  we rely on the runtime laziness to initialize on the first run for
  benchmarks that do so.

• All files located in benches/instantiation are now loaded for
  benchmarking instead of a hardcoded list. This makes it a bit easier
  to throw files into the directory and have them benchmarked instead of
  having to recompile when working with new files.

• Finally a module deserialization benchmark was added to measure the
  time it takes to deserialize a precompiled module from disk (inspired
  by discussion on #3787)

While I was at it I also upped some limits to be able to instantiate
cfallin's spidermonkey.wasm.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 10 2022 at 21:10):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 10 2022 at 21:40):

alexcrichton merged PR #3790.

Last updated: Nov 22 2024 at 16:03 UTC