Wasmtime GitHub notifications bot (Feb 09 2022 at 23:48): Wasmtime GitHub notifications bot (Feb 09 2022 at 23:48):sunfishcode opened PR #3786 from sunfishcode/fix-compilation-on-nightly to main:
Other than doc updates, this just contains bytecodealliance/cap-std#235,
a fix for compilation errors on Rust nightly that look like this:error[E0308]: mismatched types --> cap-primitives/src/fs/via_parent/rename.rs:22:58 | 22 | let (old_dir, old_basename) = open_parent(old_start, &old_path)?; | ^^^^^^^^^ expected struct `Path`, found opaque type | ::: cap-primitives/src/rustix/fs/dir_utils.rs:67:48 | 67 | pub(crate) fn strip_dir_suffix(path: &Path) -> impl Deref<Target = Path> + '_ { | ------------------------------ the found opaque type | = note: expected struct `Path` found opaque type `impl Deref<Target = Path>`<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 09 2022 at 23:52):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 10 2022 at 00:22):sunfishcode merged PR #3786.
Last updated: Nov 22 2024 at 17:03 UTC