Stream: git-wasmtime

Topic: wasmtime / PR #3784 [RFC] ISLE: Re-implement ValueSlice

Wasmtime GitHub notifications bot (Feb 09 2022 at 13:01):

uweigand opened PR #3784 from isle-valuelist to main:

The current definition of ValueSlice is not usable, since any call to
a constructor returning a ValueSlice will extend the mutable borrow
on the context taken by the constructor call, with the result that it
cannot be passed to any other constructor ever.

Re-implement ValueSlice as a pair of a ValueList identifer plus an
offset into the list. This type can simply be copied without requiring
a borrow on the context.

CC @cfallin @fitzgen

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 24 2022 at 22:09):

uweigand updated PR #3784 from isle-valuelist to main.

Wasmtime GitHub notifications bot (Feb 24 2022 at 22:29):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 24 2022 at 22:29):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 24 2022 at 22:29):

cfallin created PR review comment:

s/is/its/

Wasmtime GitHub notifications bot (Feb 24 2022 at 22:31):

uweigand updated PR #3784 from isle-valuelist to main.

Wasmtime GitHub notifications bot (Feb 24 2022 at 22:32):

uweigand submitted PR review.

Wasmtime GitHub notifications bot (Feb 24 2022 at 22:32):

uweigand created PR review comment:

Fixed, thanks!

Wasmtime GitHub notifications bot (Feb 24 2022 at 22:43):

uweigand updated PR #3784 from isle-valuelist to main.

Wasmtime GitHub notifications bot (Feb 24 2022 at 23:24):

cfallin merged PR #3784.

Last updated: Dec 23 2024 at 12:05 UTC