Stream: git-wasmtime

Topic: wasmtime / PR #3777 Pooling allocator: Default for alloca...

Wasmtime GitHub notifications bot (Feb 08 2022 at 17:02):

cfallin opened PR #3777 from memfd-allocator-feature to main:

Thanks to @peterheune for noticing this!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 08 2022 at 17:02):

cfallin requested peterhuene for a review on PR #3777.

Wasmtime GitHub notifications bot (Feb 08 2022 at 17:03):

peterhuene submitted PR review.

Wasmtime GitHub notifications bot (Feb 08 2022 at 17:08):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 08 2022 at 17:08):

alexcrichton created PR review comment:

Could this use cfg(memfd) to have the right behavior on macOS/Windows with memfd enabled, and could this also be structured like:

if cfg!(memfd) {
    Self::ReuseAffinity
} else {
    Self::NextAvailable
}

to avoid conditional compilation?

Wasmtime GitHub notifications bot (Feb 08 2022 at 17:12):

cfallin updated PR #3777 from memfd-allocator-feature to main.

Wasmtime GitHub notifications bot (Feb 08 2022 at 17:13):

cfallin updated PR #3777 from memfd-allocator-feature to main.

Wasmtime GitHub notifications bot (Feb 08 2022 at 17:13):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 08 2022 at 17:13):

cfallin created PR review comment:

Ah yes, fixed, thanks!

Wasmtime GitHub notifications bot (Feb 08 2022 at 18:29):

cfallin merged PR #3777.

Last updated: Nov 22 2024 at 16:03 UTC