Stream: git-wasmtime

Topic: wasmtime / PR #3777 Pooling allocator: Default for alloca...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2022 at 17:02):

cfallin opened PR #3777 from memfd-allocator-feature to main:

Thanks to @peterheune for noticing this!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2022 at 17:02):

cfallin requested peterhuene for a review on PR #3777.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2022 at 17:03):

peterhuene submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2022 at 17:08):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2022 at 17:08):

alexcrichton created PR review comment:

Could this use cfg(memfd) to have the right behavior on macOS/Windows with memfd enabled, and could this also be structured like:

if cfg!(memfd) {
    Self::ReuseAffinity
} else {
    Self::NextAvailable
}

to avoid conditional compilation?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2022 at 17:12):

cfallin updated PR #3777 from memfd-allocator-feature to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2022 at 17:13):

cfallin updated PR #3777 from memfd-allocator-feature to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2022 at 17:13):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2022 at 17:13):

cfallin created PR review comment:

Ah yes, fixed, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 08 2022 at 18:29):

cfallin merged PR #3777.


Last updated: Dec 23 2024 at 12:05 UTC