Stream: git-wasmtime

Topic: wasmtime / PR #3773 ISLE: emit traps as safepoints on x64


view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2022 at 18:26):

fitzgen requested cfallin for a review on PR #3773.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2022 at 18:26):

fitzgen opened PR #3773 from x64-traps-safepoints to main:

This adds support for emitting safepoints from ISLE on x64 and makes traps safepoints, just like they used to be before they were ported to ISLE in 658c5d33c.

This doesn't actually affect Wasmtime at all, since Wasmtime never uses resumable traps, and we unwind the stack for regular traps, meaning that we never inspect the safepoint's spill slots. But maybe other Cranelift users rely on traps being safepoints, so best to keep the old behavior given that we don't have a strong reason to change it.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2022 at 18:52):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 07 2022 at 18:57):

fitzgen merged PR #3773.


Last updated: Nov 22 2024 at 17:03 UTC