Stream: git-wasmtime

Topic: wasmtime / PR #3748 cranelift/x64: lower min and max for ...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2022 at 17:29):

Mrmaxmeier opened PR #3748 from lower-umax-x64 to main:

Hey,
I noticed that umax and friends fail during lowering for i64 and smaller types (wasm doesn't seem to have non-wide integer max operators).
x86 doesn't have this functionality as an instruction, so i'm falling back to cmov -- similar to clang's codegen.

I'm new to this stuff / ISLE though.. In particular, my ISLE rules generate a spurious movl %edi, %edi, but I can't figure out why this happens :upside_down_face:
I've included codegen tests for reference, and will drop those if you decide to merge.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2022 at 17:39):

Mrmaxmeier edited PR #3748 from lower-umax-x64 to main:

Hey,
I noticed that umax and friends fail during lowering for i64 and smaller types (wasm doesn't seem to have non-wide integer max operators).
x86 doesn't have this functionality as an instruction, so i'm falling back to cmov -- similar to clang's codegen.

I'm new to this stuff / ISLE though.. In particular, my ISLE rules generate a spurious movl %edi, %edi, but I can't figure out why this happens :upside_down_face:
I've included codegen tests for reference, and will drop those if you decide to merge.

It might make sense to rebase/redo this on #3682, though select seems to do/handle a lot more than my this test-and-cmove implementation.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2022 at 17:49):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2022 at 17:49):

abrown created PR review comment:

@Mrmaxmeier, thanks for the PR! I just wanted to point out here that this is another instance of #3744 (no action needed, just wanted to capture instances of that problem).

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2022 at 18:28):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2022 at 18:28):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 01 2022 at 18:28):

fitzgen created PR review comment:

Just for consistency with the rest of the file, could you use

;; SSE.

instead of "wide" and use ;; instead of ; comments? Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 11 2022 at 19:06):

Mrmaxmeier updated PR #3748 from lower-umax-x64 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 11 2022 at 19:44):

Mrmaxmeier updated PR #3748 from lower-umax-x64 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 11 2022 at 19:45):

Mrmaxmeier has marked PR #3748 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 14 2022 at 18:21):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 14 2022 at 18:21):

cfallin merged PR #3748.


Last updated: Dec 23 2024 at 12:05 UTC