Wasmtime GitHub notifications bot (Jan 31 2022 at 21:59): Wasmtime GitHub notifications bot (Jan 31 2022 at 21:59):uweigand opened PR #3745 from move-emit to main:
Even though the implementation of emit and emit_safepoint may
be platform-specific, the interface ought to be common so that
other code in prelude.isle may safely call these constructors.This patch moves the definition of emit (from all platforms)
and emit_safepoint (s390x only) to prelude.isle. This required
adding an emit_safepoint implementation to aarch64 and x64 as
well - the latter is still a stub as special move mitosis
handling will be required.CC @cfallin @fitzgen -- as discussed here: https://github.com/bytecodealliance/wasmtime/pull/3724
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 31 2022 at 22:08):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jan 31 2022 at 22:43):fitzgen merged PR #3745.
Last updated: Nov 22 2024 at 17:03 UTC