Wasmtime GitHub notifications bot (Jan 27 2022 at 18:41): Wasmtime GitHub notifications bot (Jan 27 2022 at 18:41):alexcrichton opened PR #3732 from configure-ufd to main:
This commit updates how the
uffdfeature of Wasmtime is enabled and
used. Previously to useuffdusers needed to do a few things:
- Enable the pooling allocator
- Enable paged memory initialization
- Enable the
uffdfeature at compile timeIf any one of these were omitted, however, then
uffdwas silently not
used or otherwise wasn't beneficial (e.g. forgetting paged memory
initialization means that memories would be all initialized
immediately).This commit changes this configuration to instead have consumers
explicitly requestuffdas part of enabling the pooling allocation
strategy. This makes it clear thatuffdis only enabled for the
pooling allocator, and requests to enable it when the feature isn't
compiled in (or is the wrong platform) can return an error indicating
what happened.This does sort of effectively revert #3245 which allows enabling paged
memory initialization independent of uffd, but at this time I can't
quite remember what the motivation was for that PR so I'm hoping that
this can jog a memory!<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 27 2022 at 19:31):alexcrichton closed without merge PR #3732.
Last updated: Nov 22 2024 at 16:03 UTC