Stream: git-wasmtime

Topic: wasmtime / PR #3725 cranelift: Use `emit` helper function...

Wasmtime GitHub notifications bot (Jan 25 2022 at 18:01):

fitzgen opened PR #3725 from use-emit-helper-aarch64 to main:

...instead of pushing to the emitted_insts vec directly.

cc @uweigand

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 25 2022 at 18:01):

fitzgen requested cfallin for a review on PR #3725.

Wasmtime GitHub notifications bot (Jan 25 2022 at 18:03):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jan 25 2022 at 18:04):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jan 25 2022 at 18:04):

bjorn3 created PR review comment:

Can emitted_insts be made private after this? That would prevent similar issues in the future.

Wasmtime GitHub notifications bot (Jan 25 2022 at 18:20):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jan 25 2022 at 18:20):

fitzgen created PR review comment:

Unfortunately, that doesn't work because different backends have slightly different definitions of emit so it is part of the ISLE-generated trait that is implemented for each backend and those implementations need to be able to push onto emitted_insts.

Wasmtime GitHub notifications bot (Jan 25 2022 at 18:36):

fitzgen merged PR #3725.

Last updated: Dec 23 2024 at 13:07 UTC