Stream: git-wasmtime

Topic: wasmtime / PR #3723 ISLE: Allow emitting safepoint insns


view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 13:25):

uweigand opened PR #3723 from isle-safepoint to main:

Change the implementation of emitted_insts in IsleContext from
a plain vector of instructions into a vector of tuples, where
the second element is a boolean that indicates whether this
instruction should be emitted as a safepoint.

This allows targets to emit safepoint insns via ISLE.

@cfallin @fitzgen

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 13:44):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 13:44):

bjorn3 created PR review comment:

This probably increases memory usage by a considerable amount due to padding. Maybe we could instead have an is_safepoint method on instructions?

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 13:49):

uweigand submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 13:49):

uweigand created PR review comment:

This vector tends to be small, it only holds the machine instructions emitted for a single CLIF instruction. So I don't think memory usage is really any concern here ...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 13:59):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 13:59):

bjorn3 created PR review comment:

Right, forgot about that.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 16:56):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 16:56):

cfallin merged PR #3723.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 17:57):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 17:57):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 17:57):

fitzgen created PR review comment:

Could we use self.emit(..) here to hide the bool tuple entry, which is noise/distracting/raises irrelevant questions for new code readers who stumble upon this?

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 17:57):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 17:57):

fitzgen created PR review comment:

Ah I see this already merged, I'll send a follow up PR.


Last updated: Dec 23 2024 at 12:05 UTC