Wasmtime GitHub notifications bot (Jan 24 2022 at 11:56): Wasmtime GitHub notifications bot (Jan 24 2022 at 11:56):uweigand opened PR #3718 from clif-insndata to main:
Attempt to match a Jump instruction in ISLE will currently lead to the
generated files not compiling. This is because the definition of the
InstructionData enum in clif.isle does not match the actual type used
in Rust code.Specifically, clif.isle erroneously omits the ValueList variable-length
argument entry if the format does not use a typevar operand. This is
the case for Jump and a few other formats. The problem is caused by
a bug in the gen_isle routine in meta/src/gen_inst.rs.CC @cfallin @fitzgen
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jan 24 2022 at 17:33):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jan 24 2022 at 17:33):fitzgen merged PR #3718.
Last updated: Dec 23 2024 at 13:07 UTC