Stream: git-wasmtime

Topic: wasmtime / PR #3717 s390x: Refactor branch and jumptable ...


view this post on Zulip Wasmtime GitHub notifications bot (Jan 24 2022 at 11:18):

uweigand opened PR #3717 from s390x-branchtarget to main:

The BranchTarget abstraction is no longer needed, since all branches are
being emitted using a MachLabel target. Remove BranchTarget and simply
use MachLabel everywhere a branch target is required. (This brings the
s390x back-end in line with what x64 does as well.)

In addition, simplify jumptable emission by moving all instructions
that do not depend on the internal label (i.e. the conditional branch
to the default label, as well as the scaling the index register) out of
the combined JTSequence instruction.

This refactoring will make moving branch generation to ISLE easier.

CC @cfallin

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jan 24 2022 at 11:23):

uweigand updated PR #3717 from s390x-branchtarget to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 16:55):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 25 2022 at 16:55):

cfallin merged PR #3717.


Last updated: Nov 22 2024 at 17:03 UTC