Stream: git-wasmtime

Topic: wasmtime / PR #3708 Add syntax for cold blocks to CLIF.

Wasmtime GitHub notifications bot (Jan 20 2022 at 23:46):

cfallin opened PR #3708 from cold-blocks-clif to main:

This commit adds support for denoting cold blocks in the CLIF text
format as follows:

function %f() {
block0(...):
  ...

cold block1:
  ...

cold block2(...):
  ...

block3:
  ...

With this syntax, we are able to see the cold-block flag in CLIF, we can
write tests using it, and it is preserved when round-tripping.

Fixes #3701.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.
• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.
• [ ] This PR contains test cases, if meaningful.
• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 21 2022 at 00:38):

cfallin updated PR #3708 from cold-blocks-clif to main.

Wasmtime GitHub notifications bot (Jan 21 2022 at 00:50):

cfallin updated PR #3708 from cold-blocks-clif to main.

Wasmtime GitHub notifications bot (Jan 21 2022 at 00:51):

cfallin edited PR #3708 from cold-blocks-clif to main:

This commit adds support for denoting cold blocks in the CLIF text
format as follows:

function %f() {
block0(...):
  ...

block1 cold:
  ...

block2(...) cold:
  ...

block3:
  ...

With this syntax, we are able to see the cold-block flag in CLIF, we can
write tests using it, and it is preserved when round-tripping.

Fixes #3701.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.
• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.
• [ ] This PR contains test cases, if meaningful.
• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jan 21 2022 at 00:52):

cfallin requested fitzgen for a review on PR #3708.

Wasmtime GitHub notifications bot (Jan 21 2022 at 07:30):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jan 21 2022 at 18:19):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jan 21 2022 at 18:19):

fitzgen merged PR #3708.

Last updated: Dec 23 2024 at 13:07 UTC