Stream: git-wasmtime

Topic: wasmtime / PR #3680 Remove the CodeSink interface in favo...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2022 at 18:12):

bjorn3 opened PR #3680 from remove_code_sink to main:

This should improve performance by allowing memcpy instead of copying each individual byte and by avoiding clones at a couple of places.

Fixes https://github.com/bytecodealliance/wasmtime/issues/2824

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2022 at 19:47):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2022 at 19:47):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2022 at 19:47):

cfallin created PR review comment:

Can we factor this loop out into a helper of some sort? I think it helped readability in the original code to have things factored as a consequence of separate trait impls; it might be nice to have e.g. mach_reloc_to_reloc() and map the vector through it or something similar.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 11 2022 at 19:47):

cfallin created PR review comment:

Likewise here and below for stackmaps: factor out into separate conversion functions.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 12 2022 at 16:19):

bjorn3 updated PR #3680 from remove_code_sink to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 12 2022 at 16:19):

bjorn3 created PR review comment:

Done

view this post on Zulip Wasmtime GitHub notifications bot (Jan 12 2022 at 16:19):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 12 2022 at 18:47):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 12 2022 at 18:47):

cfallin merged PR #3680.

Last updated: Dec 23 2024 at 12:05 UTC