Stream: git-wasmtime

Topic: wasmtime / PR #3664 Refactor fuzzing configuration and so...

Wasmtime GitHub notifications bot (Jan 07 2022 at 18:38):

alexcrichton opened PR #3664 from fuzz-limits to main:

This PR has two commits, the first being the primary one, so solve a recent fuzz bug that came up where a module was timing out while fuzzing. The commits themselves have many more details as to what's going on here. The high-level summary is:

• All fuzz targets are refactored to have one mode of wasm-smith-based configuration.
• Some fuzz targets were shuffled around.
• The cranelift debug verifier is disabled for modules that might have more than 10 functions.

Wasmtime GitHub notifications bot (Jan 07 2022 at 18:38):

alexcrichton requested fitzgen for a review on PR #3664.

Wasmtime GitHub notifications bot (Jan 07 2022 at 18:42):

alexcrichton updated PR #3664 from fuzz-limits to main.

Wasmtime GitHub notifications bot (Jan 07 2022 at 18:50):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jan 07 2022 at 19:18):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jan 07 2022 at 19:18):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jan 07 2022 at 19:18):

fitzgen created PR review comment:

This new fuzz target never initializes the logger or calls log_wasm on the generated bytes, so debugging failures for it will be annoying. Care to add a call to log_wasm here? (Which will internally initialize the env_logger)

Wasmtime GitHub notifications bot (Jan 07 2022 at 19:18):

fitzgen created PR review comment:

Ditto here.

Wasmtime GitHub notifications bot (Jan 07 2022 at 19:24):

alexcrichton updated PR #3664 from fuzz-limits to main.

Wasmtime GitHub notifications bot (Jan 07 2022 at 19:27):

alexcrichton updated PR #3664 from fuzz-limits to main.

Wasmtime GitHub notifications bot (Jan 07 2022 at 19:28):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jan 07 2022 at 19:28):

alexcrichton created PR review comment:

Oops excellent point

Wasmtime GitHub notifications bot (Jan 07 2022 at 20:37):

alexcrichton updated PR #3664 from fuzz-limits to main.

Wasmtime GitHub notifications bot (Jan 07 2022 at 21:12):

alexcrichton merged PR #3664.

Last updated: Dec 23 2024 at 12:05 UTC