Wasmtime GitHub notifications bot (Dec 17 2021 at 19:49): Wasmtime GitHub notifications bot (Dec 17 2021 at 19:49):alexcrichton opened PR #3618 from better-names to main:
This commit moves the aarch64 backend's ISLE to be more similar to the
x64 backend's ISLE where one-liner instruction builders are used for
various forms of instructions instead of always using the
constructor-per-variant-of-Inst. Overall I think this change worked
out quite well and sets up some naming idioms as well for various forms
of instructions.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 17 2021 at 21:42):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Dec 17 2021 at 22:49):alexcrichton updated PR #3618 from better-names to main.
Wasmtime GitHub notifications bot (Dec 17 2021 at 23:28):alexcrichton merged PR #3618.
Last updated: Dec 23 2024 at 12:05 UTC