Stream: git-wasmtime

Topic: wasmtime / PR #3602 aarch64: Migrate some bit-ops to ISLE

Wasmtime GitHub notifications bot (Dec 14 2021 at 21:54):

alexcrichton opened PR #3602 from isle-6-bitops to main:

This commit migrates these instructions to ISLE:

• bnot
• band
• bor
• bxor
• band_not
• bor_not
• bxor_not

The translations were relatively straightforward but the interesting
part here was trying to reduce the duplication between all these
instructions. I opted for a route that's similar to what the lowering
does today, having a decl which takes the ALUOp and then performs
further pattern matching internally. This enabled each instruction's
lowering to be pretty simple while we still get to handle all the fancy
cases of shifts, constants, etc, for each instruction.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 14 2021 at 21:54):

alexcrichton requested fitzgen for a review on PR #3602.

Wasmtime GitHub notifications bot (Dec 14 2021 at 21:56):

alexcrichton updated PR #3602 from isle-6-bitops to main.

Wasmtime GitHub notifications bot (Dec 14 2021 at 22:16):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 14 2021 at 22:43):

alexcrichton updated PR #3602 from isle-6-bitops to main.

Wasmtime GitHub notifications bot (Dec 15 2021 at 16:41):

alexcrichton merged PR #3602.

Last updated: Dec 06 2025 at 06:05 UTC