Stream: git-wasmtime

Topic: wasmtime / PR #3586 x64: expand FloatCC enum in ISLE

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 19:49):

abrown opened PR #3586 from isle-enum-floatcc to main:

To lower the various select rules in ISLE, we need visibility of the FloatCC enum variants, not just a primitive type. This change generates the ISLE enum for FloatCC in clif.isle.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 19:51):

abrown updated PR #3586 from isle-enum-floatcc to main.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 19:53):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 19:53):

bjorn3 created PR review comment:

Can you do this for all enum operands including IntCC?

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 21:01):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 21:01):

abrown created PR review comment:

So IntCC, AtomicRmwOp, and TrapCode from immediates.rs?

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 21:06):

bjorn3 created PR review comment:

Yes

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 21:06):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 10 2021 at 23:55):

abrown updated PR #3586 from isle-enum-floatcc to main.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 10 2021 at 23:56):

abrown updated PR #3586 from isle-enum-floatcc to main.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 10 2021 at 23:56):

abrown requested fitzgen for a review on PR #3586.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 10 2021 at 23:56):

abrown requested cfallin for a review on PR #3586.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2021 at 00:12):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2021 at 00:12):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2021 at 01:57):

abrown updated PR #3586 from isle-enum-floatcc to main.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2021 at 01:58):

abrown updated PR #3586 from isle-enum-floatcc to main.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2021 at 02:31):

abrown merged PR #3586.

Last updated: Nov 22 2024 at 16:03 UTC