Stream: git-wasmtime

Topic: wasmtime / PR #3584 cranelift codegen & filetests: silenc...

Wasmtime GitHub notifications bot (Dec 03 2021 at 18:35):

pchickey opened PR #3584 from pch/rust_1.57_warnings to main:

I don't have the expertise in this part of the codebase to know whether we should actually delete these fields.

In RuntestContext, it looks like the dead code struct member heaps is load-bearing because of unsafe pointer shenanigans.

Either way, this should unblock CI jobs that are now failing due to the upgrade to the latest stable rust.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 03 2021 at 18:48):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Dec 03 2021 at 18:48):

bjorn3 created PR review comment:

    _heaps: Vec<HeapMemory>,

Wasmtime GitHub notifications bot (Dec 03 2021 at 18:49):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 03 2021 at 20:36):

pchickey merged PR #3584.

Last updated: Dec 23 2024 at 12:05 UTC