Stream: git-wasmtime

Topic: wasmtime / PR #3568 Make the trap name for `unreachable` ...


view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2021 at 19:34):

sunfishcode opened PR #3568 from sunfishcode/unreachable-message to main:

Following up on WebAssembly/wasi-sdk#210, this makes the trap message
for unreachable traps more descriptive of what actually caused the
trap, so that it doesn't sound like maybe Wasmtime itself executed a
unreachable!() macro in Rust.

Before:

wasm trap: unreachable
wasm backtrace:
     [...]

After:

wasm trap: wasm `unreachable` instruction executed
wasm backtrace:
     [...]

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2021 at 19:41):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2021 at 23:55):

sunfishcode merged PR #3568.


Last updated: Dec 23 2024 at 12:05 UTC