Stream: git-wasmtime

Topic: wasmtime / PR #3568 Make the trap name for `unreachable` ...

Wasmtime GitHub notifications bot (Nov 29 2021 at 19:34):

sunfishcode opened PR #3568 from sunfishcode/unreachable-message to main:

Following up on WebAssembly/wasi-sdk#210, this makes the trap message
for unreachable traps more descriptive of what actually caused the
trap, so that it doesn't sound like maybe Wasmtime itself executed a
unreachable!() macro in Rust.

Before:

wasm trap: unreachable
wasm backtrace:
     [...]

After:

wasm trap: wasm `unreachable` instruction executed
wasm backtrace:
     [...]

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 29 2021 at 19:41):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 29 2021 at 23:55):

sunfishcode merged PR #3568.

Last updated: Nov 22 2024 at 17:03 UTC