Stream: git-wasmtime

Topic: wasmtime / PR #3552 x64: allow vector types in `select` move

Wasmtime GitHub notifications bot (Nov 19 2021 at 18:34):

abrown opened PR #3552 from fix-3173 to main:

As reported in #3173, the select instruction fails an assertion when it is given v128 types as operands. This change relaxes the assertion to allow the same type of XMM move that occurs for the f32 and f64 types. This fixes #3173 in the old lower.rs code temporarily until the relatively complex select lowering can be ported to ISLE.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 19 2021 at 18:52):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 19 2021 at 19:24):

abrown merged PR #3552.

Last updated: Dec 06 2025 at 06:05 UTC