Stream: git-wasmtime

Topic: wasmtime / PR #3550 x64: Add test for a fixed issue

Wasmtime GitHub notifications bot (Nov 19 2021 at 16:17):

alexcrichton opened PR #3550 from close-simd-fuzz to main:

This commit adds a test from #3337 which is an issue that was fixed
in #3506 due to moving imul lowering rules to ISLE which fixed the
underlying issue of accidentally not falling through to the necessary
case for general i64x2.mul multiplication.

Closes #3337

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 19 2021 at 16:44):

alexcrichton updated PR #3550 from close-simd-fuzz to main.

Wasmtime GitHub notifications bot (Nov 19 2021 at 17:19):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 19 2021 at 17:19):

cfallin merged PR #3550.

Last updated: Dec 23 2024 at 12:05 UTC