Stream: git-wasmtime

Topic: wasmtime / PR #3544 Move `insertlane` to ISLE

Wasmtime GitHub notifications bot (Nov 18 2021 at 16:05):

alexcrichton opened PR #3544 from fix-movsd-issue to main:

This also fixes a bug where movsd was incorrectly used with a memory
operand for insertlane, causing it to actually zero the upper bits
instead of preserving them.

Note that the insertlane logic still exists in lower.rs because it's
used as a helper for a few other instruction lowerings which aren't
migrated to ISLE yet. This commit also adds a helper in ISLE itself for
those other lowerings to use when they get implemented.

Closes #3216

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Last updated: Oct 23 2024 at 20:03 UTC