Stream: git-wasmtime

Topic: wasmtime / PR #3544 Move `insertlane` to ISLE


view this post on Zulip Wasmtime GitHub notifications bot (Nov 18 2021 at 16:05):

alexcrichton opened PR #3544 from fix-movsd-issue to main:

This also fixes a bug where movsd was incorrectly used with a memory
operand for insertlane, causing it to actually zero the upper bits
instead of preserving them.

Note that the insertlane logic still exists in lower.rs because it's
used as a helper for a few other instruction lowerings which aren't
migrated to ISLE yet. This commit also adds a helper in ISLE itself for
those other lowerings to use when they get implemented.

Closes #3216

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->


Last updated: Dec 23 2024 at 12:05 UTC