Stream: git-wasmtime

Topic: wasmtime / PR #3538 aarch64: Remove manual sign extension...

Wasmtime GitHub notifications bot (Nov 16 2021 at 21:56):

alexcrichton opened PR #3538 from rm-sign-extend to main:

Currently the lowering for iconst will sign-extend the payload value
of the iconst instruction itself, but the payload is already
sign-extended to this isn't necessary. This commit removes the redundant
sign extension.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 16 2021 at 22:14):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 16 2021 at 22:47):

alexcrichton merged PR #3538.

Wasmtime GitHub notifications bot (Nov 16 2021 at 23:47):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Nov 16 2021 at 23:47):

bjorn3 created PR review comment:

get_constant doesn't sign extend the immediate. It returns the raw bits. cg_clif chooses to zero extend immediates. https://github.com/bytecodealliance/wasmtime/blob/bae4ec642798ff448ca88eab771b6fcea71e7884/cranelift/codegen/src/inst_predicates.rs#L60

Last updated: Nov 22 2024 at 16:03 UTC