Stream: git-wasmtime

Topic: wasmtime / PR #3537 isle: Migrate f32const/f64const to ISLE


view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 17:14):

alexcrichton opened PR #3537 from isle-fconst to main:

This moves the f32const and f64const instructions from lower.rs to
ISLE. I was originally going to add something else but due to the
isle.rs's manual use of constructor_imm(..) it necessitated filling
out the imm cases for f32/f64 constants, so I figured I'd go ahead and
move these instructions as well.

The special case for 0 constants which use xorp{s,d} is preserved from
lower.rs today, but a special case isn't added for the all-ones
constant. The comment says to use cmpeqp{s,d} but as discovered on
other recent PRs that's not quite sufficient because comparing a
register against itself which happens to be NaN wouldn't work, so
something else will be required (perhaps pcmpeq or similar? I figured
I'd defer to later)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 17:56):

alexcrichton updated PR #3537 from isle-fconst to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 18:10):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 18:10):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 18:10):

fitzgen created PR review comment:

;; `f64` immediates.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 18:10):

fitzgen created PR review comment:

;; Special case for `f32` zero immediates to use `xorps`.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 18:10):

fitzgen created PR review comment:

;; Special case for `f64` zero immediates to use `xorpd`.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 18:10):

fitzgen created PR review comment:

;; `f32` immediates.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 18:10):

fitzgen created PR review comment:

;; Integer immediates.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 18:31):

alexcrichton updated PR #3537 from isle-fconst to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 20:19):

alexcrichton merged PR #3537.


Last updated: Dec 23 2024 at 12:05 UTC