pchickey opened PR #3510 from pch/instance_pre_clone
to main
:
The clone should be reasonably inexpensive: Clone for Module is just an
Arc, and Clone for Definition should also just be an Arc on the HostFunc
or Instance variants. An InstancePre shouldnt contain any
Definition::Extern variants because there is not yet a Store associated
with it- right?<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey updated PR #3510 from pch/instance_pre_clone
to main
.
pchickey edited PR #3510 from pch/instance_pre_clone
to main
:
Its a manually written impl, not a derive, because
InstancePre<T>: Clone
is not bound byT: Clone
.The clone should be reasonably inexpensive: Clone for
Module
is just an
Arc, and Clone forDefinition
should also just be an Arc on theHostFunc
orInstance
variants. AnInstancePre
shouldnt contain any
Definition::Extern
variants because there is not yet aStore
associated
with it- right?<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey requested alexcrichton for a review on PR #3510.
alexcrichton submitted PR review.
alexcrichton merged PR #3510.
Last updated: Dec 23 2024 at 12:05 UTC