Stream: git-wasmtime

Topic: wasmtime / PR #3503 Add a configuration option to force "...

Wasmtime GitHub notifications bot (Nov 03 2021 at 15:17):

alexcrichton opened PR #3503 from static-max to main:

In poking around at some things earlier today I realized that one
configuration option for memories we haven't exposed from embeddings
like the CLI is to forcibly limit the size of memory growth and force
using a static memory style. This means that the CLI, for example, can't
limit memory growth by default and memories are only limited in size by
what the OS can give and the wasm's own memory type. This configuration
option means that the CLI can artificially limit the size of wasm linear
memories.

Additionally another motivation for this is for testing out various
codegen ramifications of static/dynamic memories. This is the only way
to force a static memory, by default, for wasm64 memories with no
maximum size listed for example.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 03 2021 at 15:44):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 03 2021 at 15:44):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 03 2021 at 15:44):

cfallin created PR review comment:

maybe min(bound_bytes, maximum.unwrap_or(usize::MAX)) to avoid the match and Option awkwardness?

Wasmtime GitHub notifications bot (Nov 03 2021 at 16:56):

alexcrichton updated PR #3503 from static-max to main.

Wasmtime GitHub notifications bot (Nov 03 2021 at 16:56):

alexcrichton created PR review comment:

Ah yes indeed!

Wasmtime GitHub notifications bot (Nov 03 2021 at 16:56):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 03 2021 at 21:50):

alexcrichton merged PR #3503.

Last updated: Dec 23 2024 at 12:05 UTC