Wasmtime GitHub notifications bot (Nov 01 2021 at 20:38): Wasmtime GitHub notifications bot (Nov 01 2021 at 20:38):cfallin requested pchickey for a review on PR #3502.
Wasmtime GitHub notifications bot (Nov 01 2021 at 20:38):cfallin opened PR #3502 from ifcmp-sp to main:
This opcode was removed as part of the old-backend cleanup in #3446.
While this opcode will definitely go away eventually, it is
unfortunately still used today in Lucet (as we just discovered while
working to upgrade Lucet's pinned Cranelift version). Lucet is
deprecated and slated to eventually be completely sunset in favor of
Wasmtime; but until that happens, we need to keep this opcode.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 01 2021 at 20:54):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Nov 01 2021 at 21:04):cfallin merged PR #3502.
Last updated: Nov 22 2024 at 16:03 UTC