adamrk opened PR #3498 from skip-debug-for-dead-code
to main
:
Here's an attempt at fixing https://github.com/bytecodealliance/wasmtime/issues/3403
When encountering a subprogram that is dead code (as indicated by the
dead code proposal
https://dwarfstd.org/ShowIssue.php?issue=200609.1), don't generate debug
output for the subprogram or any of its children.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
I'm not personally really all that familiar with this code, but it seems to me like
skip_children
should be reset back tofalse
at some point after all children have been skipped?
adamrk submitted PR review.
adamrk created PR review comment:
Ugh, of course. I'll fix that and update the test to make sure it's done properly.
adamrk updated PR #3498 from skip-debug-for-dead-code
to main
.
alexcrichton submitted PR review.
adamrk updated PR #3498 from skip-debug-for-dead-code
to main
.
adamrk updated PR #3498 from skip-debug-for-dead-code
to main
.
adamrk updated PR #3498 from skip-debug-for-dead-code
to main
.
alexcrichton submitted PR review.
alexcrichton merged PR #3498.
Last updated: Dec 23 2024 at 12:05 UTC