Stream: git-wasmtime

Topic: wasmtime / PR #3498 Skip generating DWARF info for dead code

Wasmtime GitHub notifications bot (Oct 31 2021 at 22:40):

adamrk opened PR #3498 from skip-debug-for-dead-code to main:

Here's an attempt at fixing https://github.com/bytecodealliance/wasmtime/issues/3403

When encountering a subprogram that is dead code (as indicated by the
dead code proposal
https://dwarfstd.org/ShowIssue.php?issue=200609.1), don't generate debug
output for the subprogram or any of its children.

Wasmtime GitHub notifications bot (Nov 01 2021 at 14:32):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 01 2021 at 14:32):

alexcrichton created PR review comment:

I'm not personally really all that familiar with this code, but it seems to me like skip_children should be reset back to false at some point after all children have been skipped?

Wasmtime GitHub notifications bot (Nov 01 2021 at 14:36):

adamrk submitted PR review.

Wasmtime GitHub notifications bot (Nov 01 2021 at 14:36):

adamrk created PR review comment:

Ugh, of course. I'll fix that and update the test to make sure it's done properly.

Wasmtime GitHub notifications bot (Nov 04 2021 at 21:54):

adamrk updated PR #3498 from skip-debug-for-dead-code to main.

Wasmtime GitHub notifications bot (Nov 05 2021 at 15:05):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 07 2021 at 07:33):

adamrk updated PR #3498 from skip-debug-for-dead-code to main.

Wasmtime GitHub notifications bot (Nov 07 2021 at 07:45):

adamrk updated PR #3498 from skip-debug-for-dead-code to main.

Wasmtime GitHub notifications bot (Nov 07 2021 at 07:51):

adamrk updated PR #3498 from skip-debug-for-dead-code to main.

Wasmtime GitHub notifications bot (Nov 08 2021 at 15:31):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 08 2021 at 15:31):

alexcrichton merged PR #3498.

Last updated: Nov 22 2024 at 16:03 UTC