Stream: git-wasmtime

Topic: wasmtime / PR #3497 Misc meta crate cleanups

view this post on Zulip Wasmtime GitHub notifications bot (Oct 31 2021 at 19:00):

bjorn3 opened PR #3497 from misc_meta_simplifications to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2021 at 17:05):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2021 at 17:10):

cfallin created PR review comment:

Could you add a comment why this is unreachable? Also, if our only return cases are Some(..), then I think we should just return a &str, if the cases without docstrings are truly unreachable.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2021 at 17:10):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2021 at 17:10):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2021 at 17:18):

bjorn3 updated PR #3497 from misc_meta_simplifications to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2021 at 17:18):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2021 at 17:18):

bjorn3 created PR review comment:

Done

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2021 at 17:20):

bjorn3 updated PR #3497 from misc_meta_simplifications to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2021 at 18:24):

cfallin merged PR #3497.

Last updated: Dec 23 2024 at 13:07 UTC