Stream: git-wasmtime

Topic: wasmtime / PR #3494 Check cranelift benchmarks in CI

Wasmtime GitHub notifications bot (Oct 30 2021 at 17:44):

nilsmartel opened PR #3494 from patch-1 to main:

• [ ] This has been discussed in issue https://github.com/bytecodealliance/wasmtime/issues/3436

• [ ] This PR ensures that the cranelift benchmarks are performed (unless they are specifically ignored, right now they still are) to combat regressions

Hello peers!
Very junior contributor here.
Quite possibly this is not the correct place to include this rather trivial line of code, and since all benches are ignored per default on master, I am unsure of this pr isn't about significantly more than just this.

Though if I haven't misunderstood the usage of the CI, this seems to be the appropriate place in code, to start benchmarks.

I hope you have a beautiful day, feel free to critisise my misunderstandings.
Nils

Wasmtime GitHub notifications bot (Oct 30 2021 at 17:53):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Oct 30 2021 at 17:53):

bjorn3 created PR review comment:

cargo check --benches will check all benchmarks without running them.

Wasmtime GitHub notifications bot (Oct 31 2021 at 12:07):

nilsmartel updated PR #3494 from patch-1 to main.

Wasmtime GitHub notifications bot (Oct 31 2021 at 12:09):

nilsmartel created PR review comment:

I see now, that I misunderstood the issue itself.
I will fix this up.

Would it also make sense to create another CI check, to verify that the benchmarks are running?
I am not sure, if there's an existing strategy (or desire to have one) to protect against regressions in the CLIF format and the way it's getting executed.

Wasmtime GitHub notifications bot (Oct 31 2021 at 12:09):

nilsmartel submitted PR review.

Wasmtime GitHub notifications bot (Nov 01 2021 at 14:33):

alexcrichton merged PR #3494.

Last updated: Nov 22 2024 at 16:03 UTC