Wasmtime GitHub notifications bot (Oct 26 2021 at 17:22): Wasmtime GitHub notifications bot (Oct 26 2021 at 17:22):fitzgen opened PR #3476 from logging-in-cranelift-test-compile to main:
With the old backends, this would log the lowered+legalized clif, but the log is
useles now with the new backends. Logging the disasm is the new moral
equivalent.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Oct 26 2021 at 17:22):fitzgen requested cfallin for a review on PR #3476.
Wasmtime GitHub notifications bot (Oct 26 2021 at 17:25):bjorn3 created PR review comment:
There are still a couple of optimization passes that runs on clif ir like canonicalize_nans, licm, gvn and a couple others.
Wasmtime GitHub notifications bot (Oct 26 2021 at 17:25):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Oct 26 2021 at 17:37):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Oct 26 2021 at 17:37):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Oct 26 2021 at 17:37):cfallin created PR review comment:
That's true, but the intent of this log output is to show the final output, not the intermediate optimized code; if anyone needs to see that to debug, it's always present at
trace!()-level (as printed by the compilation driver in cranelift-codegen).
Wasmtime GitHub notifications bot (Oct 26 2021 at 18:00):fitzgen merged PR #3476.
Last updated: Nov 22 2024 at 16:03 UTC