Stream: git-wasmtime

Topic: wasmtime / PR #3476 cranelift: in `test_compile` filetest...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 26 2021 at 17:22):

fitzgen opened PR #3476 from logging-in-cranelift-test-compile to main:

With the old backends, this would log the lowered+legalized clif, but the log is
useles now with the new backends. Logging the disasm is the new moral
equivalent.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 26 2021 at 17:22):

fitzgen requested cfallin for a review on PR #3476.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 26 2021 at 17:25):

bjorn3 created PR review comment:

There are still a couple of optimization passes that runs on clif ir like canonicalize_nans, licm, gvn and a couple others.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 26 2021 at 17:25):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 26 2021 at 17:37):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 26 2021 at 17:37):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 26 2021 at 17:37):

cfallin created PR review comment:

That's true, but the intent of this log output is to show the final output, not the intermediate optimized code; if anyone needs to see that to debug, it's always present at trace!()-level (as printed by the compilation driver in cranelift-codegen).

view this post on Zulip Wasmtime GitHub notifications bot (Oct 26 2021 at 18:00):

fitzgen merged PR #3476.


Last updated: Dec 23 2024 at 12:05 UTC