Stream: git-wasmtime

Topic: wasmtime / PR #3472 Remove some uses of `foo.expect(&form...

Wasmtime GitHub notifications bot (Oct 25 2021 at 22:55):

fitzgen requested cfallin for a review on PR #3472.

Wasmtime GitHub notifications bot (Oct 25 2021 at 22:55):

fitzgen opened PR #3472 from no-expect-format to main:

This eagerly evaluates the format! and produces a String with a heap
allocation, regardless whether foo is Some/Ok or None/Err. Using
foo.unwrap_or_else(|| panic!(...)) makes it so that the error message
formatting is only evaluated if foo is None/Err.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 25 2021 at 23:13):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Oct 26 2021 at 00:35):

fitzgen updated PR #3472 from no-expect-format to main.

Wasmtime GitHub notifications bot (Oct 26 2021 at 02:31):

fitzgen merged PR #3472.

Last updated: Nov 22 2024 at 17:03 UTC