fitzgen requested cfallin for a review on PR #3472.
fitzgen opened PR #3472 from no-expect-format
to main
:
This eagerly evaluates the
format!
and produces aString
with a heap
allocation, regardless whetherfoo
isSome
/Ok
orNone
/Err
. Using
foo.unwrap_or_else(|| panic!(...))
makes it so that the error message
formatting is only evaluated iffoo
isNone
/Err
.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
cfallin submitted PR review.
fitzgen updated PR #3472 from no-expect-format
to main
.
fitzgen merged PR #3472.
Last updated: Dec 23 2024 at 12:05 UTC