Wasmtime GitHub notifications bot (Oct 20 2021 at 22:30): Wasmtime GitHub notifications bot (Oct 20 2021 at 22:30):cfallin requested alexcrichton for a review on PR #3466.
Wasmtime GitHub notifications bot (Oct 20 2021 at 22:30):cfallin opened PR #3466 from regalloc-0.0.32 to main:
This pulls in a change from regalloc.rs to address some quadratic behavior
(thanks @adamrk!).It appears that some allocation heuristics have changed slightly since
0.0.31, so some of the golden-output filetests are updated as well.
Ideally we would rely more on runtests rather than golden-compilation
tests; but for now this is sufficient. (I'm not sure exactly what in
regalloc.rs changed to alter these heuristics; it's actually been almost
a year since the 0.0.31 release with several refactorings and tweaks
merged since then.)Fixes #3441.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Oct 20 2021 at 22:30):cfallin requested fitzgen for a review on PR #3466.
Wasmtime GitHub notifications bot (Oct 20 2021 at 22:39):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Oct 20 2021 at 23:07):cfallin merged PR #3466.
Last updated: Nov 22 2024 at 16:03 UTC