Wasmtime GitHub notifications bot (Oct 19 2021 at 16:53): Wasmtime GitHub notifications bot (Oct 19 2021 at 16:53):alexcrichton opened PR #3462 from fix-fuzz-bug to main:
This commit fixes an issue in Cranelift where legalization of
heap_addrinstructions (used by wasm to represent heap accesses) could
be off-by-two where loads that should be valid were actually treated as
invalid. The bug here happened in an optimization where tests against
odd constants were being altered to tests against even constants by
subtracting one from the limit instead of adding one to the limit. The
comment around this area has been updated in accordance with a little
more math-stuff as well to help future readers.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Oct 19 2021 at 16:55):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Oct 19 2021 at 18:19):alexcrichton merged PR #3462.
Last updated: Oct 23 2024 at 20:03 UTC