Stream: git-wasmtime

Topic: wasmtime / PR #3456 List exports of an instance in linkin...

Wasmtime GitHub notifications bot (Oct 16 2021 at 21:40):

adamrk opened PR #3456 from improve-import-error-with-linking to main:

Took a stab at https://github.com/bytecodealliance/wasmtime/issues/3388. The error message is now:

unknown import: instance `foo` exporting `bar` has not been defined

when module-linking is enabled. Hopefully that's clear for both de-sugared two-level imports and actual instance imports.

Wasmtime GitHub notifications bot (Oct 18 2021 at 18:29):

adamrk updated PR #3456 from improve-import-error-with-linking to main.

Wasmtime GitHub notifications bot (Oct 18 2021 at 20:05):

adamrk updated PR #3456 from improve-import-error-with-linking to main.

Wasmtime GitHub notifications bot (Oct 18 2021 at 20:09):

adamrk updated PR #3456 from improve-import-error-with-linking to main.

Wasmtime GitHub notifications bot (Oct 19 2021 at 15:22):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 19 2021 at 15:22):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 19 2021 at 15:22):

alexcrichton created PR review comment:

Instead of using a String error can this use an anyhow::Result<Definition> like the rest of the crate?

Wasmtime GitHub notifications bot (Oct 19 2021 at 20:28):

adamrk updated PR #3456 from improve-import-error-with-linking to main.

Wasmtime GitHub notifications bot (Oct 19 2021 at 20:29):

adamrk submitted PR review.

Wasmtime GitHub notifications bot (Oct 19 2021 at 20:29):

adamrk created PR review comment:

:+1: done

Wasmtime GitHub notifications bot (Oct 19 2021 at 21:43):

alexcrichton created PR review comment:

I think that this map_err would probably be good to fold into _get_by_import because it'd be relevant to other callers (if ever) and it's a bit odd to build up the error string across two functions.

Wasmtime GitHub notifications bot (Oct 19 2021 at 21:43):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 19 2021 at 21:43):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 20 2021 at 19:36):

adamrk updated PR #3456 from improve-import-error-with-linking to main.

Wasmtime GitHub notifications bot (Oct 20 2021 at 19:36):

adamrk created PR review comment:

done

Wasmtime GitHub notifications bot (Oct 20 2021 at 19:36):

adamrk submitted PR review.

Wasmtime GitHub notifications bot (Oct 20 2021 at 21:31):

alexcrichton merged PR #3456.

Last updated: Dec 23 2024 at 12:05 UTC