Stream: git-wasmtime

Topic: wasmtime / PR #3444 Experimental feature i2t

Wasmtime GitHub notifications bot (Oct 11 2021 at 20:06):

brianjjones opened PR #3444 from add_i2t_feature to main:

i2t is an optional feature that exposes a new function
in the wasi-nn crate API called convert_image. This
function utilizes the image2tensor crate to open an image
and convert it to a tensor of the desired size. Image
classification is a very common use case for wasi-nn,
this feature aims to make that easier and faster. In
addition, exposing this function in Wasmtime will allow
AssemblyScript WebAssembly code to image2tensor, even
though its written In Rust. Including it in Wasmtime also
results in roughly 50% faster conversion times vs including
image2tensor in the Rust WebAssembly code itself. When
built with the i2t feature, the convert_image function
is then available to be used by the wasi-nn Rust and
AssemblyScript bindings.

See PR for info:
https://github.com/bytecodealliance/wasi-nn/pull/58

Wasmtime GitHub notifications bot (Oct 11 2021 at 21:32):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Oct 11 2021 at 21:32):

bjorn3 created PR review comment:

This is not allowed. When publishing to crates.io cargo will error if you try to modify the source directory. You are only allowed to modify the OUT_DIR.

Wasmtime GitHub notifications bot (Oct 11 2021 at 23:23):

brianjjones submitted PR review.

Wasmtime GitHub notifications bot (Oct 11 2021 at 23:23):

brianjjones created PR review comment:

Ah, good to know. I'll see if I can come up with an alternate way to achieve this.

Wasmtime GitHub notifications bot (Oct 12 2021 at 00:34):

brianjjones updated PR #3444 from add_i2t_feature to main.

Wasmtime GitHub notifications bot (Oct 12 2021 at 18:12):

brianjjones updated PR #3444 from add_i2t_feature to main.

Wasmtime GitHub notifications bot (Jan 12 2023 at 21:00):

brianjjones closed without merge PR #3444.

Last updated: Dec 23 2024 at 12:05 UTC