Wasmtime GitHub notifications bot (Oct 06 2021 at 20:11): Wasmtime GitHub notifications bot (Oct 06 2021 at 20:11):alexcrichton opened PR #3422 from release-process to main:
This change revamps the release process for Wasmtime and intends to make
it nearly 100% automated for major release and hopefully still pretty
simple for patch releases. New workflows are introduced as part of
this commit:
- Once a month a PR is created with major version bumps
Specifically hinted commit messages to the
mainbranch will get
tagged and pushed to the main repository.On tags we'll now not only build releases after running CI but
additionally crates will be published to crates.io.In conjunction with other changes this means that the release process
for a new major version of Wasmtime is simply merging a PR. Patch
releases will involve running some steps locally but most of the
nitty-gritty should be simply merging the PR that's generated.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Oct 06 2021 at 20:50):bjorn3 created PR review comment:
This can use GITHUB_TOKEN, right? Only pull request runs for branches on forks get a read-only token AFAIK. All other runs (including scheduled runs) should get a write token. One downside though is that according to the docs using GITHUB_TOKEN will prevent a workflow run for the pull request being scheduled to prevent accidentaly recursive workflows.
Wasmtime GitHub notifications bot (Oct 06 2021 at 20:50):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Oct 06 2021 at 20:53):bjorn3 created PR review comment:
Why did you add this to the main workflow? It should only publish in the publish-to-cratesio workflow, right?
Wasmtime GitHub notifications bot (Oct 06 2021 at 20:53):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Oct 06 2021 at 20:54):bjorn3 edited PR review comment.
Wasmtime GitHub notifications bot (Oct 06 2021 at 20:56):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Oct 06 2021 at 20:56):bjorn3 created PR review comment:
Major versions of Wasmtime are released once-a-month. Most of this is automatic
Wasmtime GitHub notifications bot (Oct 07 2021 at 14:24):alexcrichton updated PR #3422 from release-process to main.
Wasmtime GitHub notifications bot (Oct 18 2021 at 17:37):alexcrichton requested sunfishcode for a review on PR #3422.
Wasmtime GitHub notifications bot (Oct 26 2021 at 14:16):alexcrichton updated PR #3422 from release-process to main.
Wasmtime GitHub notifications bot (Oct 26 2021 at 14:47):sunfishcode submitted PR review.
Wasmtime GitHub notifications bot (Oct 26 2021 at 14:47):sunfishcode submitted PR review.
Wasmtime GitHub notifications bot (Oct 26 2021 at 14:47):sunfishcode created PR review comment:
Can the grep pattern here start with
^to reduce accidental matches if Cargo.toml somehow doesn't contain what we expect?
Wasmtime GitHub notifications bot (Oct 26 2021 at 15:24):alexcrichton updated PR #3422 from release-process to main.
Wasmtime GitHub notifications bot (Oct 26 2021 at 15:25):alexcrichton merged PR #3422.
Last updated: Dec 23 2024 at 12:05 UTC