Stream: git-wasmtime

Topic: wasmtime / PR #3401 Remove ancient register allocation

Wasmtime GitHub notifications bot (Sep 30 2021 at 18:42):

bnjbvr opened PR #3401 from remove-old-regalloc to main:

There's still a lot that can be done, but that'll be enough playing for tonight :-)

This removes the old register allocation, and the entire folder regalloc that contained related code, like live range analysis, etc. and quite a lot in binemit too (maybe that can be entirely removed too with additional effort?).

Wasmtime GitHub notifications bot (Sep 30 2021 at 18:49):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2021 at 18:50):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2021 at 18:50):

bjorn3 created PR review comment:

Can you add a FIXME to make this non-optional?

Wasmtime GitHub notifications bot (Sep 30 2021 at 18:51):

bnjbvr updated PR #3401 from remove-old-regalloc to main.

Wasmtime GitHub notifications bot (Sep 30 2021 at 18:51):

bnjbvr submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2021 at 18:51):

bnjbvr created PR review comment:

        // FIXME: make this non optional
        let backend = isa.get_mach_backend().expect("only mach backends nowadays");

Wasmtime GitHub notifications bot (Sep 30 2021 at 18:51):

bnjbvr updated PR #3401 from remove-old-regalloc to main.

Wasmtime GitHub notifications bot (Sep 30 2021 at 18:52):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2021 at 18:52):

cfallin created PR review comment:

More generally, I expect that we'll continue to tweak the data structures to remove Option<>s on new bits and delete the old bits; the CLIF function representation still has some bits that can go (jt_offsets for example?) too.

Wasmtime GitHub notifications bot (Sep 30 2021 at 18:55):

bnjbvr submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2021 at 18:55):

bnjbvr created PR review comment:

I'd expect that too, yeah. The fact that so many things were marked pub (and not pub(crate)) make it so the compiler is not seeing all the dead code out there.

Wasmtime GitHub notifications bot (Sep 30 2021 at 19:27):

bnjbvr merged PR #3401.

Wasmtime GitHub notifications bot (Oct 01 2021 at 18:45):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Oct 01 2021 at 18:45):

bjorn3 created PR review comment:

Can EncCursor be removed entirely? It doesn't update encodings anymore.

Wasmtime GitHub notifications bot (Oct 04 2021 at 08:09):

bnjbvr submitted PR review.

Wasmtime GitHub notifications bot (Oct 04 2021 at 08:09):

bnjbvr created PR review comment:

Sounds like yes!

Last updated: Jan 10 2026 at 02:36 UTC