alexcrichton opened PR #3394 from validate-parallel
to main
:
We already validate wasm functions in parallel when compiling a module,
but the same parallelism wasn't available to theModule::validate
API.
This commit peforms a minor tweak to the validate-the-whole-module API
to validate all functions in parallel in the same manner that module
compilation does.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen submitted PR review.
bjorn3 submitted PR review.
bjorn3 created PR review comment:
Would it be possible to avoid this intermediate vec and instead directly push each functionbto a worker thread? For example by implementing
rayon::ParallelIterator
?
alexcrichton submitted PR review.
alexcrichton created PR review comment:
Not easily, no, but it's something we can investigate in the future if necessary.
alexcrichton merged PR #3394.
Last updated: Dec 23 2024 at 12:05 UTC