Stream: git-wasmtime

Topic: wasmtime / PR #3394 Validate functions in parallel in `Mo...

Wasmtime GitHub notifications bot (Sep 29 2021 at 19:56):

alexcrichton opened PR #3394 from validate-parallel to main:

We already validate wasm functions in parallel when compiling a module,
but the same parallelism wasn't available to the Module::validate API.
This commit peforms a minor tweak to the validate-the-whole-module API
to validate all functions in parallel in the same manner that module
compilation does.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 29 2021 at 20:20):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 29 2021 at 20:50):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Sep 29 2021 at 20:50):

bjorn3 created PR review comment:

Would it be possible to avoid this intermediate vec and instead directly push each functionbto a worker thread? For example by implementing rayon::ParallelIterator?

Wasmtime GitHub notifications bot (Sep 30 2021 at 14:09):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Sep 30 2021 at 14:09):

alexcrichton created PR review comment:

Not easily, no, but it's something we can investigate in the future if necessary.

Wasmtime GitHub notifications bot (Sep 30 2021 at 14:09):

alexcrichton merged PR #3394.

Last updated: Nov 22 2024 at 16:03 UTC