Wasmtime GitHub notifications bot (Sep 27 2021 at 16:07): Wasmtime GitHub notifications bot (Sep 27 2021 at 16:07):alexcrichton opened PR #3390 from rm-lightbeam to main:
This commit removes the Lightbeam backend from Wasmtime as per [RFC 14].
This backend hasn't received maintenance in quite some time, and as [RFC
14] indicates this doesn't meet the threshold for keeping the code
in-tree, so this commit removes it.A fast "baseline" compiler may still be added in the future. The
addition of such a backend should be in line with [RFC 14], though, with
the principles we now have for stable releases of Wasmtime. I'll close
out Lightbeam-related issues once this is merged.[RFC 14]: https://github.com/bytecodealliance/rfcs/pull/14
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 27 2021 at 16:25):bjorn3 created PR review comment:
Maybe keep this for in the future if a new backend is added?
Wasmtime GitHub notifications bot (Sep 27 2021 at 16:25):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Sep 27 2021 at 16:25):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Sep 27 2021 at 17:11):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Sep 27 2021 at 17:11):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Sep 27 2021 at 17:11):cfallin created PR review comment:
Pre-existing, but s/Cranelift will unconditionally use Cranelift/Wasmtime will unconditionally use Cranelift/ ?
Wasmtime GitHub notifications bot (Sep 27 2021 at 17:11):cfallin created PR review comment:
s/the Cranelift/Cranelift/
Wasmtime GitHub notifications bot (Sep 27 2021 at 17:26):alexcrichton updated PR #3390 from rm-lightbeam to main.
Wasmtime GitHub notifications bot (Sep 27 2021 at 17:27):alexcrichton created PR review comment:
This can be added in the future and otherwise I think it would be confusing to have a flag that basically does nothing.
Wasmtime GitHub notifications bot (Sep 27 2021 at 17:27):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Sep 27 2021 at 17:27):alexcrichton merged PR #3390.
Last updated: Nov 22 2024 at 16:03 UTC