Stream: git-wasmtime

Topic: wasmtime / PR #3383 Cranelift AArch64: Fix the VanyTrue i...

Wasmtime GitHub notifications bot (Sep 23 2021 at 10:26):

akirilov-arm opened PR #3383 from vany_true to main:

Fixes #3305.

Wasmtime GitHub notifications bot (Sep 23 2021 at 12:37):

akirilov-arm updated PR #3383 from vany_true to main.

Wasmtime GitHub notifications bot (Sep 23 2021 at 17:53):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 23 2021 at 17:53):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 23 2021 at 17:53):

cfallin created PR review comment:

I'm possibly misunderstanding, but doesn't this only work for the "any" case, not the "all" case, since in the latter case half the lanes will be new artificial zeroes (possibly, if the upper bits of the i64 lanes are zeroes)?

Wasmtime GitHub notifications bot (Sep 23 2021 at 17:56):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (Sep 23 2021 at 17:56):

akirilov-arm created PR review comment:

Yes, you are absolutely right, but there is a separate arm for VallTrue with 64-bit elements on line 2343.

Wasmtime GitHub notifications bot (Sep 23 2021 at 17:59):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 23 2021 at 17:59):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 23 2021 at 17:59):

cfallin created PR review comment:

Ah, I missed that, thank you! Could you add a comment referring to the case above and noting that VallTrue with 64x2 doesn't land here?

Wasmtime GitHub notifications bot (Sep 24 2021 at 10:37):

akirilov-arm updated PR #3383 from vany_true to main.

Wasmtime GitHub notifications bot (Sep 24 2021 at 16:26):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 24 2021 at 16:26):

cfallin merged PR #3383.

Last updated: Oct 23 2024 at 20:03 UTC