Stream: git-wasmtime

Topic: wasmtime / PR #3380 Implement `Iabs` for the interpreter

Wasmtime GitHub notifications bot (Sep 22 2021 at 12:00):

dheaton-arm opened PR #3380 from implement-iabs to main:

Implemented Iabs to return the absolute integer value with wrapping.

Copyright (c) 2021, Arm Limited

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 22 2021 at 12:05):

dheaton-arm edited PR #3380 from implement-iabs to main:

Implemented Iabs for the Cranelift interpreter to return the absolute integer value with wrapping.

Copyright (c) 2021, Arm Limited

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 22 2021 at 13:18):

dheaton-arm updated PR #3380 from implement-iabs to main.

Wasmtime GitHub notifications bot (Sep 22 2021 at 14:05):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Sep 22 2021 at 14:05):

bjorn3 created PR review comment:

Would it be an idea to make extractlanes and vectorizelanes on non-vector values produce and accept a single element? That way you can use the same code for scalar and vector types without any duplication.

Wasmtime GitHub notifications bot (Sep 22 2021 at 14:23):

dheaton-arm submitted PR review.

Wasmtime GitHub notifications bot (Sep 22 2021 at 14:23):

dheaton-arm created PR review comment:

Would this make sense as a separate patch? Since I think that would involve restructuring both extractlanes and vectorizelanes a fair bit, plus then going through the existing uses of those functions in the rest of step.rs.

Wasmtime GitHub notifications bot (Sep 22 2021 at 17:00):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 22 2021 at 17:00):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Sep 22 2021 at 17:00):

cfallin created PR review comment:

This sounds like a reasonable refactor; I also agree that it's a bit out-of-scope for this PR, but could be a followup.

Wasmtime GitHub notifications bot (Sep 22 2021 at 17:00):

cfallin merged PR #3380.

Last updated: Nov 22 2024 at 16:03 UTC